[17.0][MIG] web_widget_domain_editor_dialog: Migration to 17.0 #2875
Merged
OCA-git-bot merged 16 commits intoOCA:17.0from Jul 8, 2024
Merged
[17.0][MIG] web_widget_domain_editor_dialog: Migration to 17.0 #2875OCA-git-bot merged 16 commits intoOCA:17.0from
OCA-git-bot merged 16 commits intoOCA:17.0from
Conversation
When clicking edit the list of record an error happened due to lack of proper initialization of the default domain.
- IMP: Now it's possible to work with the domain editor when the widget has de in_dialog option. - FIX: When a boolean opertator was present in the domain, the editor dialog would raise an error as the default filter couldn't be interpretated. TT32827
The dialog needs to keep the context so translations and other things work as expected. TT45543
Contributor
|
LGTM 👍 Thanks 😄 |
CarlosRoca13
approved these changes
Jul 8, 2024
Member
|
/ocabot migration web_widget_domain_editor_dialog |
pedrobaeza
approved these changes
Jul 8, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Tested in runboat
/ocabot merge nobump
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at eb17de2. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration
cc @Tecnativa TT49927
please review @CarlosRoca13