Skip to content

[17.0][MIG] web_widget_dropdown_dynamic: Migration to 17.0#2915

Merged
OCA-git-bot merged 18 commits intoOCA:17.0from
Tecnativa:17.0-MIG-web_widget_dropdown_dynamic
Aug 14, 2024
Merged

[17.0][MIG] web_widget_dropdown_dynamic: Migration to 17.0#2915
OCA-git-bot merged 18 commits intoOCA:17.0from
Tecnativa:17.0-MIG-web_widget_dropdown_dynamic

Conversation

@CarlosRoca13
Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 commented Aug 13, 2024

@CarlosRoca13
Copy link
Copy Markdown
Contributor Author

CarlosRoca13 commented Aug 13, 2024

/ocabot migration web_widget_dropdown_dynamic

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 13, 2024
Open
33 tasks
@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

carlos-lopez-tecnativa commented Aug 13, 2024

Sorry, I couldn't test it.

image

chienandalu
chienandalu reviewed Aug 13, 2024
View reviewed changes
Comment thread web_widget_dropdown_dynamic/__manifest__.py
@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from 8199961 to 313e065 Compare August 13, 2024 12:56
@CarlosRoca13
Copy link
Copy Markdown
Contributor Author

CarlosRoca13 commented Aug 13, 2024

Changes done

carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the demo data; it helps with testing.

One question: is this module incompatible with the web_m2x_options module?
image

@CarlosRoca13
Copy link
Copy Markdown
Contributor Author

CarlosRoca13 commented Aug 14, 2024

Thanks for the notice, Carlos. The problem comes from the lack of a security control in the web_m2x_options module. I have added the fix in a new commit within this same PR.

chienandalu
chienandalu reviewed Aug 14, 2024
View reviewed changes
Comment thread web_widget_dropdown_dynamic/models/ir_filters.py Outdated
Comment thread web_widget_dropdown_dynamic/README.rst
alexey-pelykh and others added 16 commits August 14, 2024 09:17
@alexey-pelykh @CarlosRoca13
[ADD] web_widget_dropdown_dynamic
8efe13e 
[UPD] Update web_widget_dropdown_dynamic.pot

[UPD] Update web_widget_dropdown_dynamic_example.pot

[UPD] README.rst

[ADD] icon.png

[UPD] README.rst
@alexey-pelykh @CarlosRoca13
[IMP] web_widget_dropdown_dynamic: black, isort, prettier
740a878
@alexey-pelykh @CarlosRoca13
[MIG] web_widget_dropdown_dynamic: Migration to 13.0
612a8b8
@alexey-pelykh @CarlosRoca13
[UPD] Brainbean Apps => CorporateHub
0733015
@claudiagn @CarlosRoca13
Added translation using Weblate (Spanish)
cf814f6
@claudiagn @CarlosRoca13
Translated using Weblate (Spanish)
ec50843 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_dropdown_dynamic/es/
@NL66278 @CarlosRoca13
[IMP] web_widget_dropdown_dynamic: black, isort, prettier
db803eb
@NL66278 @CarlosRoca13
[MIG] web_widget_dropdown_dynamic: Migration to 14.0
d54d877
@Corneliuus @CarlosRoca13
Added translation using Weblate (German)
7829b15
@Corneliuus @CarlosRoca13
Translated using Weblate (German)
86521a7 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-14.0/web-14.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_dropdown_dynamic/de/
@BankyKmitl @CarlosRoca13
[IMP] web_widget_dropdown_dynamic: black, isort, prettier
41e85d5
@BankyKmitl @CarlosRoca13
[MIG] web_widget_dropdown_dynamic: Migration to 15.0
d07df26
@gbrito @CarlosRoca13
[16.0][MIG] web_widget_dropdown_dynamic
ccaa9f5
@CarlosRoca13
[16.0][MIG]web_widget_dropdown_dynamic: Migrate to version 16.0
237c7af
@mymage @CarlosRoca13
Added translation using Weblate (Italian)
4de472e
@CarlosRoca13
[IMP] web_widget_dropdown_dynamic: pre-commit auto fixes
920e5bf
@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from a926016 to 8f5e226 Compare August 14, 2024 07:18
@CarlosRoca13
Copy link
Copy Markdown
Contributor Author

CarlosRoca13 commented Aug 14, 2024

@chienandalu changes done 😄

@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from 8f5e226 to c3acb6e Compare August 14, 2024 07:20
chienandalu
chienandalu approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Aug 14, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 14, 2024

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2915-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fba577b into OCA:17.0 Aug 14, 2024
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 14, 2024

Congratulations, your PR was merged at 8d4cd1e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-MIG-web_widget_dropdown_dynamic branch August 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chienandalu chienandalu chienandalu approved these changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.