[18.0][MIG] web_notify: Migration to 18.0#2956
Merged
OCA-git-bot merged 73 commits intoOCA:18.0from Oct 23, 2024
Merged
Conversation
This technical module allows you to send instant notification messages from the server to the user in live.
Fix a check when comparing a user count with items within a mock call. The previous method was succeeding by pure luck because OCA test databases contain 2 users, which happens to be the amount of items within a mock "call_args" (it contains args + kwargs).
- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.
Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/
Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/
Only the admin user (sudo) is allowed to send notifications to other users. The normal users can only send notifications to themselves. This is to prevent attackers to craft malicious notifications and send them to other users using RPC. Correction based on the idea of @hbrunn
Add self-test buttons in demo environment, Updated readme to show how to test it. Add buttons to users form Do not rely on SUPERUSER_ID and avoid getattr usage
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default) * [IMP] use black color for text for default notification. * [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
It seems besides the custom channels provided in this addon it also catches messages from other channels. E.g. in this case it seems the void popup is triggered by these activity creation bus messages. **Steps to reproduce** Odoo commit: could reproduce on 5e8b667951 and 4da82776ff OCA/web commit: 2465278 * Install crm and web_notify modules * Create an activity for yourself (tried for admin user) * Empty popup appears **Attempt to solve** It seems the bus handles all messages non exclusively. I've hacked in a conditional to handle only messages from web_notify addon, but its unclear wether this does not break something else.
Currently translated at 100.0% (18 of 18 strings) Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/pt_BR/
Currently translated at 100.0% (18 of 18 strings) Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_notify/
Includes some manual fixes to silent ESLint warnings.
Currently translated at 100.0% (18 of 18 strings) Translation: web-13.0/web-13.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_notify/de/
Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/
Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/pt_BR/
When trying to use the notify function that comes from a normal user with sudo flag enabled, it wasn't letting the user access it. Adding the su flag to the check should allow sudo users using this feature.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/
Currently translated at 100.0% (19 of 19 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/
Currently translated at 100.0% (19 of 19 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/pt_BR/
- We can now set a button name to the notification action. - We can set an icon button as well. - After the button is clicked, the notification gets closed.
chienandalu
approved these changes
Oct 14, 2024
Member
chienandalu
left a comment
chienandalu
left a comment
There was a problem hiding this comment.
Test and code review. Thanks! 👍
Member
|
/ocabot migration web_notify |
sebalix
approved these changes
Oct 23, 2024
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 1f0db64. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change
_sendmany()was removed in odoo/odoo@432e375. As consequences, take advantage of_bus_send, which was introduced in odoo/odoo@432e375, as it's claimed to be more secured and simpler.Took this chance to refactor the notification service
With
_bus_send, payload passed todisplaywebNotificationis an object. In other words, the method processes 1 notification at a time.As notificationService originally close the notification after 4s, in here, there is no need to do it from our side.
webNotifTimeoutsobjectResult
web_notify_18.webm