[17.0][MIG] web_editor_class_selector: Migration to version 17.0#2991
Merged
OCA-git-bot merged 5 commits intoOCA:17.0from Nov 20, 2024
Merged
[17.0][MIG] web_editor_class_selector: Migration to version 17.0#2991OCA-git-bot merged 5 commits intoOCA:17.0from
OCA-git-bot merged 5 commits intoOCA:17.0from
Conversation
… editor. This module allows users to create custom CSS classes, which can then be selected and applied directly in the HTML editor.
…s not present Go to the website Open the editor Add text and select it, a traceback is shown
pedrobaeza
approved these changes
Nov 18, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Tested on base runboat installing the module, and working. There's any module in the repo that is breaking the styles popup toolbar, so it's not possible to be tested on regular runboat.
Member
|
/ocabot migration web_editor_class_selector |
chienandalu
approved these changes
Nov 19, 2024
Member
chienandalu
left a comment
chienandalu
left a comment
There was a problem hiding this comment.
Test and code review.
Non really blocking comment:
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-web_editor_class_selector
branch
from
063c799 to
1a2cab1
Compare
chienandalu
approved these changes
Nov 20, 2024
Member
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 955ab1d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TT51657
@Tecnativa @pedrobaeza @chienandalu could you please review this