[18.0][MIG] web_session_auto_close#3101
Conversation
This commit adds the web_session_auto_close module which purpose is to is to automatically close the session when the last odoo tab is closed or when the computer gets in idle mode. The `timeout` occurs 15 seconds after the tab has been closed or the computer got idle.
|
The mechanism doesn't work if the last tab is closed. You can go back in Odoo after the timeout. |
sbejaoui
force-pushed
the
18.0-web_session_auto_close-sbj
branch
from
3b31da7 to
ab7d4d0
Compare
please try now |
|
LGTM |
|
This PR has the |
ivs-cetmix
left a comment
ivs-cetmix
left a comment
There was a problem hiding this comment.
Hi @sbejaoui , could you please squash all technical commits?
It's not applicable. This commit comes from the bot there are no others commit from the bot.Blocking PRs with this type of argument will further reduce the number of contributors by adding constraints with no real added value to the work to be done. |
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Thank you for the migration (Code review + Functional tests)
|
/ocabot migration web_session_auto_close |
@lmignon This is what is written in the Migration guidelines I don't understand how squashing commits will reduce the number of contributors. |
@ivs-cetmix I think @lmignon wanted to say (as I said also), requiring more work (that has no value added - really) will discourage contributors. Moreover if they don't feel at ease with squashing, that is quite an advanced operation for newbies. |
rousseldenis
left a comment
rousseldenis
left a comment
There was a problem hiding this comment.
LGTM. Functionally and technically reviewed
@rousseldenis Sure! Let's remove pre-commit too, because it restraints so many great Odoo developers from contribution! And tests, does anyone really need them? Odoo App Store has no tests at all and look how many great apps are there! |
ivs-cetmix
left a comment
ivs-cetmix
left a comment
There was a problem hiding this comment.
LGTM just as an exclusion.
Let's continue the discussion here: OCA/maintainer-tools#657 (comment)
You take a wrong path... but thanks for approval. |
I don't consider following the official documentation being a wrong path. |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at e27793b. Thanks a lot for contributing to OCA. ❤️ |
7 participants
This module automatically closes inactive user sessions based on a
configurable timeout. If no activity is detected within the set
duration, the session is destroyed, and the page reloads.