[MIG] web_widget_open_tab: Migration to 18.0#3173
Conversation
…inside other forms
Currently translated at 100.0% (6 of 6 strings) Translation: web-16.0/web-16.0-web_widget_open_tab Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_open_tab/es/
CRogos
force-pushed
the
18.0-mig-web_widget_open_tab
branch
from
81c6ef8 to
7a36042
Compare
|
@amh-mw could you review? |
CRogos
force-pushed
the
18.0-mig-web_widget_open_tab
branch
from
7a36042 to
55cc4a0
Compare
There was a problem hiding this comment.
Code review only. LGTM.
@yostashiro @widadelbekkouri-odoo @jtl-mw Additional reviews?
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
Code & functional review LGTM
|
/ocabot migration web_widget_open_tab |
| } | ||
| loadAttrs(ev) { | ||
| $(ev.target).tooltip(); | ||
| return window.location.pathname + "/" + this.props.record.data.id; |
There was a problem hiding this comment.
This is not working properly. Let me explain the case:
1- Access Apps menu
2- Refresh (this way we set the window.location.pathname
3- Access the User menu (do not press F5)
4- PRess the Open Tab widget
| } | ||
| loadAttrs(ev) { | ||
| $(ev.target).tooltip(); | ||
| return window.location.pathname + "/" + this.props.record.data.id; |
There was a problem hiding this comment.
Use this:
return `/odoo/${this.props.record.resModel}/${this.props.record.data.id}`;
There was a problem hiding this comment.
I've changed it this way, because I also could not find a better solution, but the bread-crumbs and context get lost in the new tab.
There was a problem hiding this comment.
Might be, but there is no better solution, as we need to use the model if the widget is aplied in a list of a on2many field
CRogos
force-pushed
the
18.0-mig-web_widget_open_tab
branch
from
55cc4a0 to
c8950bd
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 007c966. Thanks a lot for contributing to OCA. ❤️ |
16 participants
Followup of:
#3091
#3029