Skip to content

[18.0][MIG] web_widget_domain_editor_dialog: Migration to 18.0#3232

Merged
OCA-git-bot merged 17 commits intoOCA:18.0from
Tecnativa:18.0-MIG-web_widget_domain_editor_dialog
Jul 29, 2025
Merged

[18.0][MIG] web_widget_domain_editor_dialog: Migration to 18.0#3232
OCA-git-bot merged 17 commits intoOCA:18.0from
Tecnativa:18.0-MIG-web_widget_domain_editor_dialog

Conversation

@CarlosRoca13
Copy link
Copy Markdown
Contributor

cc @Tecnativa TT54526

This PR supersedes this other one #3106, maintaining the authorship of the migration commit to fix the precommit issues.

ping @pedrobaeza @victoralmau

chienandalu and others added 16 commits July 28, 2025 07:07
When clicking edit the list of record an error happened due to lack
of proper initialization of the default domain.
- IMP: Now it's possible to work with the domain editor when the widget
has de in_dialog option.
- FIX: When a boolean opertator was present in the domain, the editor dialog
would raise an error as the default filter couldn't be interpretated.

TT32827
The dialog needs to keep the context so translations and other things
work as expected.

TT45543
@bealdav
Copy link
Copy Markdown
Member

bealdav commented Jul 28, 2025

Hi, thanks for this PR
Despite the description it is quite difficult to know what the module does.
A screenshot could fix it I suppose, thanks

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot migration web_widget_domain_editor_dialog

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 28, 2025
48 tasks
@pedrobaeza
Copy link
Copy Markdown
Member

@CarlosRoca13 can you rewrite it a bit the README and include a GIF/image?

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG-web_widget_domain_editor_dialog branch from 8fe0552 to eefd99a Compare July 29, 2025 09:53
@CarlosRoca13
Copy link
Copy Markdown
Contributor Author

Updated readme and gif

@bealdav
Copy link
Copy Markdown
Member

bealdav commented Jul 29, 2025

Thanks a lot.

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3232-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 87aee42 into OCA:18.0 Jul 29, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f3cd429. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-MIG-web_widget_domain_editor_dialog branch July 29, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.