Skip to content

[18.0][MIG] web_systray_button_init_action: Migration to 18.0#3236

Merged
OCA-git-bot merged 3 commits intoOCA:18.0from
Tecnativa:18.0-MIG_web_systray_button_init_action
Aug 26, 2025
Merged

[18.0][MIG] web_systray_button_init_action: Migration to 18.0#3236
OCA-git-bot merged 3 commits intoOCA:18.0from
Tecnativa:18.0-MIG_web_systray_button_init_action

Conversation

@CarlosRoca13
Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 commented Jul 30, 2025

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG_web_systray_button_init_action branch 2 times, most recently from cc93081 to bfaed8d Compare July 30, 2025 09:07
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Jul 30, 2025

/ocabot migration web_systray_button_init_action

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 30, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 30, 2025
Open
48 tasks
pedrobaeza
pedrobaeza approved these changes Jul 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review in runboat. Waiting for the web_responsive patch.

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG_web_systray_button_init_action branch from bfaed8d to 6522286 Compare July 31, 2025 05:02
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG_web_systray_button_init_action branch from 6522286 to 0c851eb Compare July 31, 2025 05:04
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG_web_systray_button_init_action branch from a7080f0 to 3572907 Compare July 31, 2025 05:33
@pedrobaeza pedrobaeza requested a review from victoralmau August 26, 2025 11:40
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Aug 26, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 26, 2025

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3236-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8058cae into OCA:18.0 Aug 26, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 26, 2025

Congratulations, your PR was merged at 4c3968a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-MIG_web_systray_button_init_action branch August 26, 2025 17:03
@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented Aug 29, 2025

why was this merged when its tests fail?

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Aug 29, 2025

It was not failing when merged, as if so, ocabot won't merge it.

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Aug 29, 2025

@CarlosRoca13 please check what's happening.

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Sep 4, 2025

The issue is with web_responsive. Not a real fix, but setting it as a rebel module works: #3275

@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented Sep 4, 2025

my question was why ocabot merged it, given it must have failed in the now deleted commit it did too - i want to rely on ocabot to only merge green commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@victoralmau victoralmau victoralmau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlosRoca13 @pedrobaeza @OCA-git-bot @hbrunn @StefanRijnhart @victoralmau