[MIG] web_save_discard_button: Migration to 18.0

[julienCozo]

Migration to 18.0

[pedrobaeza]

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

[julienCozo]

Hello @pedrobaeza ,
My bad, it should be nice now.
Thank you

[pedrobaeza]

/ocabot migration web_save_discard_button

[remi-filament]

Thanks @julienCozo tested OK on Runboat

[innovara]

Functional tests are okay for me but there are still a number of references to 17.0 particularly in web_save_discard_button/static/description/index.html and web_save_discard_button/README.rst.
I've done a migration myself but it wouldn't be appropriate to open another PR. See here: https://github.com/innovara/web/tree/18.0-mig-web_save_discard_button

[julienCozo]

thank you @innovara. I made the fix

[R4Alex]

@julienCozo @pedrobaeza

Is there any way to unlock this PR? It would be super cool to have already this module in 18.0

[pedrobaeza]

@R4Alex do the review on the PR: https://odoo-community.org/resources/review

[innovara]

@julienCozo I think commit [FIX] remove 17.0 references should be a fixup of the migration commit. It's all part of the migration.

[innovara]

I think the last commit fixing references to 17.0 should just be part of the migration commit. Otherwise, LGTM. Functionality tested in runboat and in my own test environment.

[R4Alex]

@pedrobaeza I think this is ready to merge, @innovara and @remi-filament already left their review and approval

[pedrobaeza]

The last two commits should be squashed together.

[CRogos]

Have you noticed a new change regarding the auto save. When you create a new contact, and change the tab of the browser, the new contact gets automatically saved.
When the intention of the module is to restore the v16 behavior, this might also be changed/configurable?

[julienCozo]

squash done @pedrobaeza

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3239-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 0817b65. Thanks a lot for contributing to OCA. ❤️