[9.0] [IMP] Web Environment Ribbon: support variables in ribbon name (eg db_name) by ThomasBinsfeld · Pull Request #621 · OCA/web

ThomasBinsfeld · 2017-05-16T08:09:49Z

Add a simple backend to web_environment_ribbon
The new method get_environment_ribbon() can be overridden to change the standard behavior
The database name is now displayed under the name, in the ribbon (can be changed by overriding the method)

(Preview on Odoo 9.0 Enterprise)

This PR is an other solution for #588

This commit adds a simple bakend to facilitate inheritance

This commit adds the database name under the ribbon name, in the ribbon

dreispt · 2017-05-16T08:12:10Z

Isn't the dbname already shown next to the legged in user (as long as you are in debug mode)?

ThomasBinsfeld · 2017-05-16T08:17:42Z

@dreispt Yes, indeed, in debug mode. But we would like to see it without enabling the debug mode.

zakiuu · 2017-05-16T08:22:10Z

-            if (strColor && validStrColour(strColor)) {
-                ribbon.css('color', strColor);
+            // Ribbon color
+            if (ribbon_data.color && validStrColour(ribbon_data.color)) {


@ThomasBinsfeld maybe an else here for a default color if something goes wrong?

@zakiuu Hi. It's the behavior before my PR. If it's an issue, we should fix it in a separate PR.

zakiuu · 2017-05-16T08:22:24Z

-            if (strBackgroundColor && validStrColour(strBackgroundColor)) {
-                ribbon.css('background-color', strBackgroundColor);
+            // Ribbon background color
+            if (ribbon_data.background_color && validStrColour(ribbon_data.background_color)) {


@ThomasBinsfeld samething here

sbidoul · 2017-05-16T14:58:45Z

+        # Add the database name to the ribbon name
+        db_name = self.env.cr.dbname
+        name = u"{name}<br/>({db_name})".format(
+            name=ir_config_model.get_param('ribbon.name'), db_name=db_name)


@ThomasBinsfeld what I had in mind was

name = ir_config_model.get_param('ribbon.name') name = name.format(db_name=db_name)

So the format can be completely determined in the configuration file.

And put this bit in a separate method that is easy to override.

@sbidoul Done !

sbidoul · 2017-05-16T15:00:49Z

+    width: 300px;
    top: 25px;
-    left: -50px;
+    left: -100px;


Can we leave the ribbon size untouched in this PR?

If we want to display on two lines, we have to change the size.

sbidoul · 2017-05-17T15:53:21Z

@ThomasBinsfeld LGTM. Can you please update the README with the new feature and an example using db_name?

…(eg db_name) (OCA#621) * [ADD] .eggs in gitignore * [IMP] Web Environment Ribbon: add backend This commit adds a simple bakend to facilitate inheritance * [IMP] Web Environment Ribbon: add the databse name This commit adds the database name under the ribbon name, in the ribbon * [IMP] Web Environment Ribbon: prepare method for ribbon name * [IMP] README: explain how to use db_name

…(eg db_name) (#621) * [ADD] .eggs in gitignore * [IMP] Web Environment Ribbon: add backend This commit adds a simple bakend to facilitate inheritance * [IMP] Web Environment Ribbon: add the databse name This commit adds the database name under the ribbon name, in the ribbon * [IMP] Web Environment Ribbon: prepare method for ribbon name * [IMP] README: explain how to use db_name

…(eg db_name) (OCA#621) * [ADD] .eggs in gitignore * [IMP] Web Environment Ribbon: add backend This commit adds a simple bakend to facilitate inheritance * [IMP] Web Environment Ribbon: add the databse name This commit adds the database name under the ribbon name, in the ribbon * [IMP] Web Environment Ribbon: prepare method for ribbon name * [IMP] README: explain how to use db_name

ThomasBinsfeld added 3 commits May 15, 2017 16:52

[ADD] .eggs in gitignore

fbdcd37

[IMP] Web Environment Ribbon: add backend

b070f66

This commit adds a simple bakend to facilitate inheritance

[IMP] Web Environment Ribbon: add the databse name

187a3e6

This commit adds the database name under the ribbon name, in the ribbon

ThomasBinsfeld mentioned this pull request May 16, 2017

add session name in web_environment_ribbon #588

Closed

zakiuu reviewed May 16, 2017

View reviewed changes

sbidoul reviewed May 16, 2017

View reviewed changes

sbidoul changed the title ~~[9.0] [IMP] Web Environment Ribbon: display DB name~~ [9.0] [IMP] Web Environment Ribbon: support variables in ribbon name (eg db_name) May 17, 2017

sbidoul added the needs fixing label May 17, 2017

[IMP] Web Environment Ribbon: prepare method for ribbon name

52d1a0f

[IMP] README: explain how to use db_name

1f04fa4

sbidoul added needs review and removed needs fixing labels May 17, 2017

sbidoul approved these changes May 17, 2017

View reviewed changes

lmignon approved these changes May 17, 2017

View reviewed changes

zakiuu approved these changes May 17, 2017

View reviewed changes

moylop260 approved these changes May 17, 2017

View reviewed changes

tarteo approved these changes May 18, 2017

View reviewed changes

yajo merged commit e05d215 into OCA:9.0 May 31, 2017

sbidoul deleted the 9.0-add_web_ribbon_backend_tbi branch May 31, 2017 09:27

sbidoul mentioned this pull request Jul 2, 2017

[10.0] web_environment_ribbon forward port #661

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[9.0] [IMP] Web Environment Ribbon: support variables in ribbon name (eg db_name)#621

[9.0] [IMP] Web Environment Ribbon: support variables in ribbon name (eg db_name)#621
yajo merged 5 commits intoOCA:9.0from
acsone:9.0-add_web_ribbon_backend_tbi

ThomasBinsfeld commented May 16, 2017

Uh oh!

dreispt commented May 16, 2017

Uh oh!

ThomasBinsfeld commented May 16, 2017

Uh oh!

zakiuu May 16, 2017

Uh oh!

ThomasBinsfeld May 16, 2017

Uh oh!

zakiuu May 16, 2017

Uh oh!

sbidoul May 16, 2017

Uh oh!

ThomasBinsfeld May 17, 2017

Uh oh!

sbidoul May 16, 2017

Uh oh!

ThomasBinsfeld May 17, 2017

Uh oh!

sbidoul commented May 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

ThomasBinsfeld commented May 16, 2017

Uh oh!

dreispt commented May 16, 2017

Uh oh!

ThomasBinsfeld commented May 16, 2017

Uh oh!

zakiuu May 16, 2017

Choose a reason for hiding this comment

Uh oh!

ThomasBinsfeld May 16, 2017

Choose a reason for hiding this comment

Uh oh!

zakiuu May 16, 2017

Choose a reason for hiding this comment

Uh oh!

sbidoul May 16, 2017

Choose a reason for hiding this comment

Uh oh!

ThomasBinsfeld May 17, 2017

Choose a reason for hiding this comment

Uh oh!

sbidoul May 16, 2017

Choose a reason for hiding this comment

Uh oh!

ThomasBinsfeld May 17, 2017

Choose a reason for hiding this comment

Uh oh!

sbidoul commented May 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants