fix(test): align local Typesense image with v30+ supported range#4
Closed
fix(test): align local Typesense image with v30+ supported range#4
Conversation
The integration spec at `spec/typesense/collections_spec.rb:156` expects
each field in the create-collection response to include `truncate_len`,
which was added to Typesense's field schema response in v30.x. The local
`docker-compose.yml` was still pinned to `typesense/typesense:29.0`, so
the spec failed locally with the field missing from the actual response:
Failure/Error: expect(result['fields']).to eq(expected_fields)
Diff: - "truncate_len" => 100,
The README compatibility table already states typesense-ruby v5.0.0
supports Typesense >= v30.0, so this just realigns local development
with the gem's stated server compatibility.
Bumping to the latest stable patch (30.2) also surfaced two new fields
on curation rule responses (`stem`, `synonyms`); the curation set test
fixtures are updated to mirror them.
After the change:
- `bundle exec rspec` reports 151 examples, 0 failures, 16 pending
(down from 27 pending: 11 specs that were skipped against Typesense
29 are now exercised against 30.2).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Replaced by upstream typesense#56. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The integration spec at
spec/typesense/collections_spec.rb:156was failing locally with:The test expects
truncate_lenin each field's schema response — Typesense added that field in v30.x. Butdocker-compose.ymlwas still pinned attypesense/typesense:29.0, so the field was missing from what the server actually returned.The README compatibility table states typesense-ruby v5.0.0 supports Typesense >= v30.0:
>= v30.0>= v5.0.0So local dev had drifted away from the gem's stated supported range. This bumps to the latest stable patch (
30.2).What changed
docker-compose.yml:typesense/typesense:29.0→typesense/typesense:30.2.spec/typesense/curation_set_spec.rbandspec/typesense/curation_sets_spec.rb: 30.2 added two new fields (stem,synonyms) to the curation rule schema response. The fixtures are updated to match what the server now returns.Verification
bundle exec rspec— 151 examples, 0 failures, 16 pending (down from 27 pending: 11 specs that wereskipped on Typesense 29 are now exercised against 30.2).🤖 Generated with Claude Code