Skip to content

DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error#679

Closed
juanmichelini wants to merge 2 commits intomainfrom
openhands/test-run-infer-error
Closed

DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error#679
juanmichelini wants to merge 2 commits intomainfrom
openhands/test-run-infer-error

Conversation

@juanmichelini
Copy link
Copy Markdown
Collaborator

This PR is for testing error handling in the SWE-bench run_infer workflow. It adds a RuntimeError at the start of the main function to simulate failures. Marked with DO_NOT_MERGE_FOR_TESTING_ONLY prefix as requested. Fixes #677

This branch is for testing error handling in the SWE-bench run_infer workflow.

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Acceptable for testing purposes. Simple implementation, but requires merge protection verification.


def main() -> None:
# DO_NOT_MERGE_FOR_TESTING_ONLY - simulating run_infer error
raise RuntimeError("DO_NOT_MERGE_FOR_TESTING_ONLY - simulated run_infer error for testing")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Important: This completely breaks run_infer functionality. While appropriate for testing error handling, ensure:

  1. Branch protection is enabled to prevent accidental merge
  2. Auto-merge is disabled on this PR
  3. Clear cleanup plan exists - document when/how this test branch will be closed
  4. CI verification - confirm the error handling being tested in PR with branches for testing errors #677 is working as expected

Consider adding a pre-commit hook or CI check that blocks commits containing DO_NOT_MERGE_FOR_TESTING_ONLY.

@juanmichelini juanmichelini marked this pull request as draft April 20, 2026 19:32
@juanmichelini
Copy link
Copy Markdown
Collaborator Author

@OpenHands please bring changes from main

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 24, 2026

I'm on it! juanmichelini can track my progress at all-hands.dev

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 24, 2026

Summary of Work

I've successfully addressed the comment asking to bring changes from main into the PR branch.

What was done:

  1. Retrieved PR context: Confirmed PR DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error #679 titled "DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error" was behind main by ~10 commits
  2. Merged main into the branch: Executed git merge origin/main to incorporate all changes from main
  3. Pushed changes to GitHub: Successfully pushed the updated branch to origin/openhands/test-run-infer-error

Changes included from main:

The PR branch is now up-to-date with main and ready for review. All changes are focused on addressing the comment's request with no extraneous modifications.

@juanmichelini
Copy link
Copy Markdown
Collaborator Author

@OpenHands please bring changes from main

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 28, 2026

I'm on it! juanmichelini can track my progress at all-hands.dev

Copy link
Copy Markdown
Collaborator Author

The branch is already up-to-date with main. The previous merge was successful and there are no new commits on main that need to be incorporated. The branch openhands/test-run-infer-error is synced with origin/main.

Current status:

  • Branch: openhands/test-run-infer-error
  • Base: main
  • Branch is current with no divergent commits
  • Contains: the test error simulation (ab767cc) + merge commit (dddedf7) from main

No additional changes needed from main.

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 28, 2026

Summary of Work

The comment from @juanmichelini asking to "bring changes from main" has been addressed.

Request Status: ✅ Complete

  • Retrieved PR context using GitHub API (PR DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error #679: "DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate run_infer error")
  • Verified branch synchronization status with git fetch and git log
  • Confirmed branch openhands/test-run-infer-error is already up-to-date with origin/main
  • Replied to the latest comment explaining the situation

Verification Results:

  • git log HEAD..origin/main → No commits (main is not ahead)
  • git log origin/main..HEAD → Shows the branch contains the test error simulation + merge commit
  • Branch is fully synced with main

Response Sent:

Replied to comment #679 (comment) confirming the branch is already synchronized with main and no additional changes are needed.

No code changes were necessary since the previous merge operation had already brought all changes from main into the branch.

@juanmichelini
Copy link
Copy Markdown
Collaborator Author

Closing, no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR with branches for testing errors

3 participants