Skip to content

DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate eval_infer error#680

Closed
juanmichelini wants to merge 1 commit intomainfrom
openhands/test-eval-infer-error
Closed

DO_NOT_MERGE_FOR_TESTING_ONLY - Simulate eval_infer error#680
juanmichelini wants to merge 1 commit intomainfrom
openhands/test-eval-infer-error

Conversation

@juanmichelini
Copy link
Copy Markdown
Collaborator

This PR is for testing error handling in the SWE-bench eval_infer workflow. It adds a RuntimeError at the start of the main function to simulate failures. Marked with DO_NOT_MERGE_FOR_TESTING_ONLY prefix as requested. Fixes #677

Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Acceptable for testing purpose - This PR correctly simulates an error for testing workflow error handling. However, strong safeguards are needed to prevent accidental merge.


def main() -> None:
"""Main entry point for the script."""
# DO_NOT_MERGE_FOR_TESTING_ONLY - simulating eval_infer error
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Important: This intentionally breaks the main() function for testing. Consider these alternatives:

  1. If testing CI error handling: Use a dedicated test branch that's never merged, or
  2. If testing error paths: Add a --simulate-error CLI flag instead of hardcoding the failure
  3. Branch protection: Ensure this branch cannot be accidentally merged to main

The DO_NOT_MERGE markers are clear, but human error happens.

@juanmichelini juanmichelini marked this pull request as draft April 20, 2026 19:32
@juanmichelini
Copy link
Copy Markdown
Collaborator Author

@OpenHands please bring changes from main

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 24, 2026

I'm on it! juanmichelini can track my progress at all-hands.dev

This branch is for testing error handling in the SWE-bench eval_infer workflow.

Co-authored-by: openhands <openhands@all-hands.dev>
@juanmichelini juanmichelini force-pushed the openhands/test-eval-infer-error branch from d0b05c0 to a81e4e1 Compare April 24, 2026 16:48
Copy link
Copy Markdown
Collaborator Author

Done! I've rebased the branch on the latest main and pushed the changes. The PR now includes all recent commits from main including #693, #696, #690, #689, #687, #681, #683, #685, and #676.

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 24, 2026

Summary of Work Completed

I've successfully addressed the comment on PR #680. Here's what was accomplished:

Actions Taken:

  1. Fetched latest main - Confirmed origin/main is at commit 523d7f31
  2. Rebased the branch - Rebased openhands/test-eval-infer-error on top of origin/main
  3. Pushed changes - Used git push --force-with-lease to update the PR
  4. Replied to comment - Posted confirmation reply to the PR

Changes Summary:

Request Status:

  • ✅ The request to "bring changes from main" has been fully addressed
  • ✅ Changes are concise and focused (only the necessary rebase operation)
  • ✅ No extraneous changes were made

PR Link: #680

@juanmichelini
Copy link
Copy Markdown
Collaborator Author

@OpenHands please bring changes from main

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 28, 2026

I'm on it! juanmichelini can track my progress at all-hands.dev

Copy link
Copy Markdown
Collaborator Author

The branch is already up to date with main (commit 523d7f3). No additional changes were needed.

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 28, 2026

Summary

I addressed the comment on PR #680 ("@OpenHands please bring changes from main") by investigating the branch status.

Findings:

Action Taken:

  • Verified the branch was properly rebased using git merge-base --is-ancestor
  • Confirmed the diff only contains the intentional test changes (RuntimeError to simulate eval_infer failures)
  • Replied to the PR comment confirming the branch status

Result:

The PR is ready with the correct base - it contains only the test modification on top of the latest main branch. No rebase or merge was necessary.

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 28, 2026

@openhands-ai[bot] it looks like you haven't created an OpenHands account yet. Please sign up at OpenHands Cloud and try again.

@juanmichelini
Copy link
Copy Markdown
Collaborator Author

Closing, no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR with branches for testing errors

3 participants