Skip to content

Fix DYNAMIC_ARCH builds with CMAKE on OSX and add corresponding test to Azure CI#3409

Merged
martin-frbg merged 35 commits intoOpenMathLib:developfrom
martin-frbg:azureosx
Dec 4, 2021
Merged

Fix DYNAMIC_ARCH builds with CMAKE on OSX and add corresponding test to Azure CI#3409
martin-frbg merged 35 commits intoOpenMathLib:developfrom
martin-frbg:azureosx

Conversation

@martin-frbg
Copy link
Copy Markdown
Collaborator

@martin-frbg martin-frbg commented Oct 15, 2021

fixes #3408 using jbouny's suggestion

@isuruf
Copy link
Copy Markdown
Contributor

isuruf commented Dec 1, 2021

@martin-frbg, what problem are you trying to solve here? Maybe I can help.

@martin-frbg
Copy link
Copy Markdown
Collaborator Author

@isuruf #3408 (cmake hitting the ARG_MAX on OSX when creating a DYNAMIC_ARCH library). I think I have got the hack suggested in the issue ticket converted into cmake syntax, I am just fumbling around to get the correct (cmake variable for the) library name into the custom linker command now.

@isuruf
Copy link
Copy Markdown
Contributor

isuruf commented Dec 2, 2021

Ah, thanks for the pointer. How about we build the shared library using the static library instead of object files and force the user to have build the static library on macOS with gcc compiler?

@martin-frbg
Copy link
Copy Markdown
Collaborator Author

Not sure that is a "legal" or desirable way of doing it. Anyway the response file mechanism seems to work, the unsolved part is just that the library name does not appear to have been built (by system.cmake) at the time the custom linker command is executed (or more likely it is not accessible in that context).

@martin-frbg martin-frbg changed the title Fix missing gfortran in OSX cmake-clang-gfortran job Fix DYNAMIC_ARCH builds with CMAKE on OSX and add corresponding test to Azure CI Dec 4, 2021
@martin-frbg martin-frbg merged commit ea09355 into OpenMathLib:develop Dec 4, 2021
@martin-frbg martin-frbg added this to the 0.3.19 milestone Dec 4, 2021
jgillis added a commit to jgillis/OpenBLAS that referenced this pull request Jan 7, 2022
jgillis added a commit to jgillis/OpenBLAS that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Build fail when linking OpenBLAS shared library with gfortran on macOS

2 participants