Fix DYNAMIC_ARCH builds with CMAKE on OSX and add corresponding test to Azure CI#3409
Merged
martin-frbg merged 35 commits intoOpenMathLib:developfrom Dec 4, 2021
martin-frbg:azureosx
Merged
Fix DYNAMIC_ARCH builds with CMAKE on OSX and add corresponding test to Azure CI#3409martin-frbg merged 35 commits intoOpenMathLib:developfrom martin-frbg:azureosx
martin-frbg merged 35 commits intoOpenMathLib:developfrom
martin-frbg:azureosx
Conversation
Contributor
|
@martin-frbg, what problem are you trying to solve here? Maybe I can help. |
Collaborator
Author
Contributor
|
Ah, thanks for the pointer. How about we build the shared library using the static library instead of object files and force the user to have build the static library on macOS with gcc compiler? |
Collaborator
Author
|
Not sure that is a "legal" or desirable way of doing it. Anyway the response file mechanism seems to work, the unsolved part is just that the library name does not appear to have been built (by system.cmake) at the time the custom linker command is executed (or more likely it is not accessible in that context). |
jgillis
added a commit
to jgillis/OpenBLAS
that referenced
this pull request
Jan 7, 2022
jgillis
added a commit
to jgillis/OpenBLAS
that referenced
this pull request
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3408 using jbouny's suggestion