Optimize the pool lock to session key lock#14
Merged
vincentbergman merged 3 commits intomasterfrom Apr 5, 2026
Merged
Conversation
added 3 commits
April 2, 2026 08:49
Replace global _pool_lock with per-key locks to eliminate session creation bottlenecks. Now concurrent requests for different devices execute fully in parallel; only same-key requests are serialized to prevent duplicate SSH connections. Changes: - Use _key_locks dict for per-session-key locking - Add double-check pattern after acquiring key lock - Add _cleanup_key_lock to prevent lock accumulation - Improve logging (debug vs info levels) - Add pyright/basedpyright config to pyproject.toml - Minor formatting and CLI improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace global _pool_lock with per-key locks to eliminate session
creation bottlenecks. Now concurrent requests for different devices
execute fully in parallel; only same-key requests are serialized to
prevent duplicate SSH connections.