interfaces: parse flags radix correctly#110
Open
klemensn wants to merge 1 commit intoOpenVoxProject:mainfrom
Open
interfaces: parse flags radix correctly#110klemensn wants to merge 1 commit intoOpenVoxProject:mainfrom
klemensn wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
Contributor
Author
|
Bugfix for new code introduced with #94. |
ifconfig(8) flags aka. printf(9) `%b` may start with hexadecimal characters: https://github.com/openbsd/src/blob/782aef866e55128b1259c9ea5c8fb1134165876d/sbin/ifconfig/ifconfig.c#L6530-L6542 This yields facter values when, e.g. both SLAAC and DHCP are enabled: ``` $ ifconfig vlan42 | grep flags vlan42: a08843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,AUTOCONF6,AUTOCONF4 mtu 1500 $ facter networking.interfaces.vlan42.flags | jq -c - +["UP","BROADCAST","RUNNING","SIMPLEX","MULTICAST","AUTOCONF6","AUTOCONF4"] ``` Signed-off-by: Klemens Nanni <kn@openbsd.org>
klemensn
force-pushed
the
interfaces-hwfeatures-hardmtu
branch
from
8a74259 to
b16a7f6
Compare
Contributor
Author
|
Now with sign-off line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifconfig(8) flags aka. printf(9)
%bmay start with hexadecimal characters:https://github.com/openbsd/src/blob/782aef866e55128b1259c9ea5c8fb1134165876d/sbin/ifconfig/ifconfig.c#L6530-L6542
This yields facter values when, e.g. both SLAAC and DHCP are enabled: