Skip to content

Updated and tested 1.12#211

Merged
nickwinder merged 2 commits intomasterfrom
nick/uwp/update-1.12
Apr 16, 2019
Merged

Updated and tested 1.12#211
nickwinder merged 2 commits intomasterfrom
nick/uwp/update-1.12

Conversation

@nickwinder
Copy link
Copy Markdown
Contributor

@nickwinder nickwinder commented Apr 16, 2019

Details

A simple update to PSPDFKit for Windows 1.12.
All tested fine.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder requested a review from pweiskircher April 16, 2019 20:27
@nickwinder nickwinder self-assigned this Apr 16, 2019
pweiskircher
pweiskircher approved these changes Apr 16, 2019
View reviewed changes
Copy link
Copy Markdown

@pweiskircher pweiskircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickwinder nickwinder merged commit 659f9da into master Apr 16, 2019
@nickwinder nickwinder deleted the nick/uwp/update-1.12 branch April 16, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pweiskircher pweiskircher pweiskircher approved these changes

Assignees

@nickwinder nickwinder

Labels

windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickwinder @pweiskircher