Skip to content

Update wrapper to PSPSDFKit for Windows 2.0#223

Merged
nickwinder merged 2 commits intomasterfrom
nick/uwp/update-2.0
May 21, 2019
Merged

Update wrapper to PSPSDFKit for Windows 2.0#223
nickwinder merged 2 commits intomasterfrom
nick/uwp/update-2.0

Conversation

@nickwinder
Copy link
Copy Markdown
Contributor

@nickwinder nickwinder commented May 21, 2019

Update wrapper to PSPSDFKit for Windows 2.0

Details

  • Update references
  • Make JsonUtils compatible.
  • update all nuget versions.
  • removed alert from library search example as this is more than fast enough now.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder self-assigned this May 21, 2019
@nickwinder nickwinder requested a review from phraemer May 21, 2019 15:44
Copy link
Copy Markdown
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, simple enough change

@nickwinder nickwinder force-pushed the nick/uwp/update-2.0 branch from c6a15eb to 39343b2 Compare May 21, 2019 20:06
@nickwinder nickwinder merged commit 7ca8638 into master May 21, 2019
@nickwinder nickwinder deleted the nick/uwp/update-2.0 branch May 21, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants