Skip to content

Align annotations changed with ios#224

Merged
nickwinder merged 2 commits intomasterfrom
nick/uwp/align-annotations-changed-with-ios
May 21, 2019
Merged

Align annotations changed with ios#224
nickwinder merged 2 commits intomasterfrom
nick/uwp/align-annotations-changed-with-ios

Conversation

@nickwinder
Copy link
Copy Markdown
Contributor

@nickwinder nickwinder commented May 21, 2019

Fixes : https://github.com/PSPDFKit/react-native/issues/196

Details

This PR changes annotation events on UWP to pass back a list of annotations like Android and iOS does.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder requested a review from phraemer May 21, 2019 15:49
@nickwinder nickwinder self-assigned this May 21, 2019
Copy link
Copy Markdown
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nickwinder nickwinder merged commit 557898d into master May 21, 2019
@nickwinder nickwinder deleted the nick/uwp/align-annotations-changed-with-ios branch May 21, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Api of onAnnotationsChanged is inconsistent

2 participants