Adds Javascript API to customize the toolbar on iOS#233
Merged
Conversation
radazzouz
force-pushed
the
rad/customize-toolbar-ios
branch
from
d81ca8f to
0ad2b37
Compare
radazzouz
force-pushed
the
rad/customize-toolbar-ios
branch
from
dc4c74e to
e9f659e
Compare
radazzouz
changed the title
steviki
reviewed
Jun 11, 2019
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
…Items and their string values
irgendeinich
approved these changes
Jun 12, 2019
nickwinder
approved these changes
Jun 12, 2019
Contributor
nickwinder
left a comment
nickwinder
left a comment
There was a problem hiding this comment.
Does not affect windows. LGTM
radazzouz
changed the title
radazzouz
pushed a commit
that referenced
this pull request
Jun 12, 2019
We can now do it from JavaScript (See #233)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Details
Adds Javascript API to customize the tool bar on iOS.
Acceptance Criteria
package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).