Skip to content

Bump version to 1.24.3#242

Merged
nickwinder merged 1 commit intomasterfrom
nick/bump-version-missed
Jul 1, 2019
Merged

Bump version to 1.24.3#242
nickwinder merged 1 commit intomasterfrom
nick/bump-version-missed

Conversation

@nickwinder
Copy link
Copy Markdown
Contributor

@nickwinder nickwinder commented Jul 1, 2019

Details

Missing version bump from pull request #238

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder requested a review from radazzouz July 1, 2019 12:52
@nickwinder nickwinder self-assigned this Jul 1, 2019
@nickwinder nickwinder mentioned this pull request Jul 1, 2019
Closed
2 tasks
radazzouz
radazzouz approved these changes Jul 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@nickwinder nickwinder merged commit 93c7814 into master Jul 1, 2019
@nickwinder nickwinder deleted the nick/bump-version-missed branch July 1, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@radazzouz radazzouz radazzouz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickwinder nickwinder

Labels

READY TO REVIEW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickwinder @radazzouz