Skip to content

Add comment to explain why we dismiss he PSPDFViewController#287

Merged
radazzouz merged 2 commits intomasterfrom
rad/add-comment-removeFromSuperview
Aug 31, 2019
Merged

Add comment to explain why we dismiss he PSPDFViewController#287
radazzouz merged 2 commits intomasterfrom
rad/add-comment-removeFromSuperview

Conversation

@radazzouz
Copy link
Copy Markdown
Contributor

@radazzouz radazzouz commented Aug 30, 2019

Details

This is a followup PR for #280. See #280 (comment)

Acceptance Criteria

  • Add comment.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz merged commit b711d29 into master Aug 31, 2019
@radazzouz radazzouz deleted the rad/add-comment-removeFromSuperview branch August 31, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant