Skip to content

Add the annotation name to the onAnnotationsChanged payload when annotation is removed on iOS#309

Merged
radazzouz merged 3 commits intomasterfrom
rad/add-annotation-name-to-payload-onAnnotationsChanged-when-removed
Oct 16, 2019
Merged

Add the annotation name to the onAnnotationsChanged payload when annotation is removed on iOS#309
radazzouz merged 3 commits intomasterfrom
rad/add-annotation-name-to-payload-onAnnotationsChanged-when-removed

Conversation

@radazzouz
Copy link
Copy Markdown
Contributor

@radazzouz radazzouz commented Oct 15, 2019

This is the iOS implementation for #283


Details

This is the payload that we send on iOS for onAnnotationsChanged when an annotation is removed:

{
  change: 'removed',
  annotations: [
    {
      uuid: '2D28DCB5-002B-4B5A-843F-F142D618838F',
      name: '2D28DCB5-002B-4B5A-843F-F142D618838F',
    }
  ]
}

An this is the Android payload:

{
  change: 'removed',
  annotations: [
    {
      name: '2D28DCB5-002B-4B5A-843F-F142D618838F',
    }
  ]
}

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
@radazzouz radazzouz merged commit 1ff0220 into master Oct 16, 2019
@radazzouz radazzouz deleted the rad/add-annotation-name-to-payload-onAnnotationsChanged-when-removed branch October 16, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants