Add more Android configuration options#345
Merged
irgendeinich merged 6 commits intomasterfrom Feb 4, 2020
Merged
Conversation
Add new showBackButtonInToolbar and onNavigationButtonClicked props to PSPDFKitView
simoarpe
approved these changes
Jan 31, 2020
android/src/main/java/com/pspdfkit/views/ReactPdfUiFragment.java
Outdated
Show resolved
Hide resolved
tomassurin
approved these changes
Jan 31, 2020
radazzouz
approved these changes
Feb 4, 2020
Contributor
There was a problem hiding this comment.
The newly added props are Android only. I tested the iOS Catalog and it runs great. This change does not impact iOS. The JS code also LGTM 👍
Here are a few suggestions:
-
On iOS we added the ability to add a custom title in #255 and we named the configuration option
toolbarTitleinstead ofcustomTitle. I would use the same naming in here for consistency. -
I would also document the use of the custom title in a Catalog example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #344
Details
Adds two new keys to the configuration prop:
showSettingsMenufor hiding and showing the view settings button in the toolbar.customTitlefor overriding the document title with a custom title that will be displayed.Adds two new props to the
PSPDFKitView:showNavigationButtonInToolbarfor enabling and disabling showing a navigation button in the main toolbar.onNavigationButtonClickedfor handling when this up button was clicked.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).