Fix two navigation buttons being shown while the search is open#347
Merged
irgendeinich merged 1 commit intomasterfrom Feb 12, 2020
Merged
Fix two navigation buttons being shown while the search is open#347irgendeinich merged 1 commit intomasterfrom
irgendeinich merged 1 commit intomasterfrom
Conversation
tomassurin
approved these changes
Feb 10, 2020
simoarpe
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When using
showNavigationButtonand opening the inline search two navigation buttons would be shown this makes sure that only one will appear at all times.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).