Include uuid in annotation removed event#349
Merged
irgendeinich merged 4 commits intomasterfrom Feb 12, 2020
Merged
Conversation
tomassurin
approved these changes
Feb 10, 2020
simoarpe
approved these changes
Feb 11, 2020
radazzouz
reviewed
Feb 11, 2020
| @@ -57,6 +57,7 @@ public void dispatch(RCTEventEmitter rctEventEmitter) { | |||
| annotationMap = new HashMap<>(); | |||
| annotationMap.put("name", annotation.getName()); | |||
| annotationMap.put("creatorName", annotation.getCreator()); | |||
Contributor
There was a problem hiding this comment.
On iOS, we are not including the creator's name when an annotation is deleted:
The change would be pretty trivial:
- [annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null]}];
+ [annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null], @"creatorName" : annotation.user ?: [NSNull null]}];@davidschreiber can you please make this change in this PR? Otherwise, I can do it myself in the PR or a followup PR.
Pinging @nickwinder, as I am not sure what Windows does when an annotation is deleted.
radazzouz
approved these changes
Feb 11, 2020
Contributor
radazzouz
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for making the iOS change, @irgendeinich!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #283
Details
uuidin the removed event.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).