Add bookmark action configuration option#354
Merged
davidschreiber merged 2 commits intomasterfrom Mar 5, 2020
Merged
Conversation
irgendeinich
approved these changes
Mar 4, 2020
android/src/main/java/com/pspdfkit/react/ConfigurationAdapter.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Reinhard Hafenscher <reinhard@pspdfkit.com>
tomassurin
approved these changes
Mar 5, 2020
simoarpe
approved these changes
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR adds the
showBookmarksActionconfiguration option to the AndroidConfigurationAdapterclass. This was the only option missing to completely hide the outline action item from the primary toolbar.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).