Adds Javascript API to customize the font picker#363
Merged
Conversation
799b33e to
39a5970
Compare
radazzouz
commented
Apr 16, 2020
steviki
approved these changes
May 7, 2020
Contributor
steviki
left a comment
There was a problem hiding this comment.
LGTM!
Just a question about the custom subclass override.
| // We use a subclassed font picker view controller to customize it. | ||
| [view.pdfController updateConfigurationWithoutReloadingWithBuilder:^(PSPDFConfigurationBuilder * _Nonnull builder) { | ||
| [builder overrideClass:PSPDFFontPickerViewController.class withClass:CustomFontPickerViewController.class]; | ||
| }]; |
Contributor
There was a problem hiding this comment.
Could we always use the custom override, so we don't need to update the configuration all the time one of these properties is set, and just fallback to the default behavior, when none of these variables are set?
irgendeinich
approved these changes
May 25, 2020
simoarpe
approved these changes
May 25, 2020
Contributor
simoarpe
left a comment
There was a problem hiding this comment.
Android part looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #320
Details
Adds Javascript API to customize the font picker.
The exposed React Native props:
Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).