fix(build): resolve typedoc type errors and add tsc gate#17
Merged
Palbahngmiyine merged 1 commit intomasterfrom Apr 20, 2026
Merged
fix(build): resolve typedoc type errors and add tsc gate#17Palbahngmiyine merged 1 commit intomasterfrom
Palbahngmiyine merged 1 commit intomasterfrom
Conversation
`pnpm run docs`(typedoc)가 tsconfig의 include(src + test) 기준으로 전체 TypeScript 컴파일을 수행하다가 4개 타입 에러로 실패하여, v6.0.0 이후 GitHub Pages 문서 배포가 막혀 있었다. CI는 Biome/Vitest/tsup(모두 esbuild 계열)만 돌려 타입 에러를 잡지 못하는 공백이 있었다. - src/lib/schemaUtils.ts: Effect.void(= Effect<void, never>)를 Effect<Date | undefined, InvalidDateError> 자리에 사용하던 것을 Effect.succeed<Date | undefined>(undefined)로 교정. - test/lib/bms-test-utils.ts: BmsChatBubbleType을 내부용 type-only import만 존재하는 kakaoOption.ts가 아니라 정식 re-export 위치인 @/models/base/kakao/bms 에서 import. - test/models/base/kakao/bms/bmsConstraints.test.ts: 콜백이 2-arg인데 it.each 튜플에 사용되지 않는 3번째 원소(`true`)가 섞여 있어 제거. - test/models/requests/messages/sendMessage.test.ts: Schema.encodeSync 결과의 scheduledDate 타입이 string | Date이므로 new Date(...) 정규화 후 getTime 비교. 추가로 회귀 방지를 위해 package.json에 `typecheck` 스크립트 (tsc --noEmit)를 신설하고 CI lint 잡에 Typecheck step을 추가한다. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm run docs(typedoc)가 tsconfig의include: ["src/**/*", "test/**/*"]로 전체 TS 컴파일을 수행하는데, 4개 타입 에러가masterHEAD에 존재Changes
Phase A — 4개 typedoc TS 에러 수정
src/lib/schemaUtils.ts:48—Effect.void(=Effect<void, never>) →Effect.succeed<Date | undefined>(undefined)test/lib/bms-test-utils.ts:8—BmsChatBubbleTypeimport 경로를 정식 re-export 위치(@/models/base/kakao/bms)로 교정test/models/base/kakao/bms/bmsConstraints.test.ts:29-44—it.each튜플의 사용되지 않는 3번째 원소(true) 제거, 2-arg 콜백과 일치화test/models/requests/messages/sendMessage.test.ts:600—encoded.scheduledDate의 정적 타입이string | Date이므로new Date(...)로 정규화 후.getTime()호출Phase B — 회귀 방지 게이트
package.json:"typecheck": "tsc --noEmit"스크립트 신설.github/workflows/ci.yml:lint잡에Typecheckstep 추가Test plan
pnpm typecheck(=tsc --noEmit) — 0 errorspnpm test:ci— 374/374 passedpnpm run docs— exit 0,docs/index.html생성 확인 (warning만 남음)pnpm build— lint + tsup 성공Follow-up
GITHUB_TOKEN으로 생성한 릴리즈 이벤트는 다음 워크플로를 트리거하지 않는 GitHub 정책이 원인.release.yml의publish이후gh workflow run build-docs.yaml --ref <tag>로 명시적 디스패치 잡을 추가할 예정.🤖 Generated with Claude Code