Add documentation and examples to VariantBuilder#1
Merged
PinkCrow007 merged 1 commit intoPinkCrow007:variant-builderfrom Jun 14, 2025
Merged
Conversation
alamb
commented
Jun 13, 2025
| /// # Example: Create an Object | ||
| /// This example shows how to create an object with two fields: | ||
| /// ```json | ||
| /// { |
Author
There was a problem hiding this comment.
@PinkCrow007 I hope you don't mind this reference, but I think it is nice to leave some sort of personal legacy in code / examples. Your name will live on whenever someone uses this code / sees these docs
| /// }, | ||
| /// { | ||
| /// "first_name": "Malthe", | ||
| /// "last_name": "Karbo" |
This was referenced Jun 13, 2025
alamb
commented
Jun 13, 2025
| /// let Variant::Object(variant_object) = variant else { | ||
| /// panic!("unexpected variant type") | ||
| /// }; | ||
| /// /* TODO: uncomment this, but now VariantObject:field is not implemented |
Author
There was a problem hiding this comment.
Filed
Owner
|
Thanks so much @alamb! I really appreciate the time and care you put into the documentation and examples!! I’m super grateful for your help and support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggestion for the kind of documentation and tests that would be nice for
VariantBuilderNote this PR is in @PinkCrow007 's repository, so if it is merged it will directly update the apache#7653 PR in the arrow repo