fix(room_booking_approval): [PPT-2340] fix self[:approval_required]#605
Merged
fix(room_booking_approval): [PPT-2340] fix self[:approval_required]#605
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes RoomBookingApproval so tentative (approval-required) events are sourced from the Bookings driver’s :tentative cache instead of :bookings, aligning with how the Bookings driver stores tentative meetings by default.
Changes:
- Update
RoomBookingApproval#find_bookings_for_approvalto read from thetentativestatus key. - Add/expand a focused driver spec to assert tentative events populate
approval_required. - Disable Ameba’s
Naming/AccessorMethodNamerule in repo config (to avoidget_*/set_*accessor naming offenses).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| drivers/place/room_booking_approval_spec.cr | Adds mocks + regression test asserting tentative events appear in approval_required. |
| drivers/place/room_booking_approval.cr | Switches lookup from bookings to tentative when building the approval cache. |
| .ameba.yml | Disables Naming/AccessorMethodName to prevent get_*/set_* naming from being linted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.