Expose highlightLines as Prism.plugins.highlightLines in that plugin#3086
Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom Sep 23, 2021
Merged
Expose highlightLines as Prism.plugins.highlightLines in that plugin#3086RunDevelopment merged 2 commits intoPrismJS:masterfrom
RunDevelopment merged 2 commits intoPrismJS:masterfrom
Conversation
Member
|
Thank you for the PR @manutepowa! I think it's good as is. Just one thing: Prism has a kinda weird build system, so you have to rebuild Prism and commit the changes. Just run |
Contributor
Author
|
Sorry @RunDevelopment Is it correct now ? Thanks |
RunDevelopment
approved these changes
Sep 23, 2021
Member
|
Sorry for the delay @manutepowa!
There's nothing to be sorry about! Thank you for taking the time to contribute to this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made a pull request with reference to this issue #1093
I have added the highlightLines function with the Prism plugin structure.
I hope it will be helpful
Thanks