Merged
Conversation
blyxxyz
reviewed
Aug 6, 2020
blyxxyz
reviewed
Aug 6, 2020
blyxxyz
requested changes
Aug 6, 2020
Collaborator
blyxxyz
left a comment
blyxxyz
left a comment
There was a problem hiding this comment.
I had a bunch of nitpicks, but this looks good overall.
blyxxyz
requested changes
Aug 7, 2020
Collaborator
blyxxyz
left a comment
blyxxyz
left a comment
There was a problem hiding this comment.
Looks great! One last thing, and then we're done.
(You can build the docs locally to see how they turn out by running make html in the docs/ directory)
Collaborator
Author
|
Should we wait until #17 before merging this? |
blyxxyz
approved these changes
Aug 7, 2020
Collaborator
blyxxyz
left a comment
blyxxyz
left a comment
There was a problem hiding this comment.
No, this looks fine to merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7