Add KeyedSynchronizer for synchronized cache loader#15
Merged
ychescale9 merged 3 commits intoReactiveCircus:mainfrom Apr 15, 2022
Merged
Conversation
dcvz
force-pushed
the
feature/synchronized-loader
branch
from
06963ec to
c128082
Compare
dcvz
force-pushed
the
feature/synchronized-loader
branch
from
c128082 to
0461d03
Compare
dcvz
changed the title
Contributor
Author
|
@ychescale9 looks like compilation was failing on JS due to test names. I've updated them now. |
Contributor
Author
|
Should also solve the concern in #14 |
Contributor
Author
|
@ychescale9 Looks like detekt was failing, should be all green now 🤞 |
Member
|
Thanks! Will take a look on the weekend. |
dcvz
force-pushed
the
feature/synchronized-loader
branch
from
7deaa25 to
06148ec
Compare
Contributor
Author
|
Thanks! Realized detekt was still catching something, checked it locally to verify now. |
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds KeyedSynchronizer and tests to synchronize cache loader -- based on previous work by @ychescale9 .