Add wasmJs support#45
Merged
ychescale9 merged 4 commits intoReactiveCircus:mainfrom Jan 4, 2024
Merged
Conversation
ychescale9
reviewed
Jan 3, 2024
Member
ychescale9
left a comment
ychescale9
left a comment
There was a problem hiding this comment.
Thanks for the contribution! are we able to move the dependency updates to a separate PR?
Contributor
Author
|
A few are needed, like coroutines. But I can revert anything strictly not needed if that works? If you don't want to merge a release candidate dependency, I understand. But it'd be cool if you could make a separate branch and put out a snapshot in the meantime if possible |
Member
|
Sure. I don't mind merging coroutines RC as I'm not planning to publish a new release soon. |
Contributor
Author
|
@ychescale9 coroutines and atomicfu had to be updated to support wasmJs. I reverted the rest and made another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.