Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There does seem to be some benefit to offloading tiktoken in a web worker, especially for thinking models on older hardware. This is a slightly different take on @samhvw8's original implementation in #2848. I used an existing library (workerpool) for simplicity.
Implementation
Screenshots
How to Test
Get in Touch
Important
Introduces worker-based token counting using
workerpool, updatesBaseProviderto utilize it, and adds tests for thetiktokenfunction.workerpoolincountTokens.ts.BaseProviderinbase-provider.tsto usecountTokenswith workers.tiktokenfunction intiktoken.tsfor token counting.tiktokenintiktoken.test.tsto verify token counting for text and image content.workerpoolas a dependency inpackage.json.esbuild.jsto include worker configuration forcountTokens.ts.knip.jsonto ignoresrc/workers/**.This description was created by
for 8224d4c. You can customize this summary. It will automatically update as commits are pushed.