Fall back to execa if VSCode terminal integration fails by cte · Pull Request #3049 · RooCodeInc/Roo-Code

cte · 2025-04-29T23:09:14Z

Context

If terminal shell integration fails then fall back to the execa terminal and automatically disable the terminal integration in the user's settings, and show a warning.

Implementation

Screenshots

before	after

How to Test

Get in Touch

Important

Adds fallback to execa terminal if VSCode shell integration fails, updates UI and tests, and modifies localization files.

Behavior:
- Adds fallback to execa terminal if VSCode shell integration fails in executeCommandTool() in executeCommandTool.ts.
- Automatically disables terminal integration in user settings and shows a warning.
UI:
- Adds CommandExecutionError component in CommandExecutionError.tsx to display shell integration warning.
- Updates ChatRow.tsx to use CommandExecutionError for shell_integration_warning messages.
Tests:
- Mocks getModels in glama.test.ts, openrouter.test.ts, requesty.test.ts, and unbound.test.ts to return predefined models.
Localization:
- Updates shell integration warning messages in multiple language files under webview-ui/src/i18n/locales/.
Misc:
- Renames getTerminalByVSCETerminal parameter from terminal to vsceTerminal in TerminalRegistry.ts and Terminal.ts.
- Removes lint command from run-tests.js.

^{This description was created by}^{for 7c010a2. You can customize this summary. It will automatically update as commits are pushed.}

changeset-bot · 2025-04-29T23:09:17Z

🦋 Changeset detected

Latest commit: 7c010a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
roo-cline	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ellipsis-dev · 2025-04-30T00:14:24Z

Hello @cte,

Thank you for your contribution! After reviewing the pull request, it seems that the changes span across multiple components and localization files, including refactoring, feature additions, and test removals. To ensure clarity and ease of review, it might be beneficial to split this pull request into smaller, more focused ones.

Here are some suggestions on how you might consider splitting the changes:

Refactoring Changes: Group all refactoring changes, such as those in esbuild.js, src/core/tools/attemptCompletionTool.ts, and src/core/tools/executeCommandTool.ts, into one pull request.
Feature Additions: Create a separate pull request for new features, like the CommandExecutionError component in webview-ui/src/components/chat/CommandExecutionError.tsx.
Localization Updates: Consider having a dedicated pull request for the removal of shell integration keys from various localization files.

This approach will help reviewers focus on specific areas and ensure a smoother review process. Let me know if you have any questions or need further assistance.

Best regards,
Ellipsis

mrubens

Looks good aside from translations

src/api/providers/__tests__/requesty.test.ts

scripts/run-tests.js

src/api/providers/fetchers/__tests__/openrouter.test.ts

mrubens · 2025-04-30T13:24:36Z

.roomodes

    {
      "slug": "test",
-      "name": "Test",
+      "name": "🧪 Test",


Ha, thank you for this!

* prompt * changeset * words

* restoreTask protobus * changeset * changeset correction * type safety change * Fix Non-UTF-8 File Handling: Improve Encoding Detection to Prevent Garbled Text and Binary Misclassification (RooCodeInc#2347) * Fix Non-UTF-8 File Handling: Improve Encoding Detection to Prevent Garbled Text and Binary Misclassification * update package-lock.json * update * update * fix * fix * fix * ENG 526/Fix: Versioned Auto Approve settings (RooCodeInc#3014) * added verisoning for autoApprove settings * removed lines from source branch * rebase * changeset * one small change * activating extension with evals.env (RooCodeInc#3041) Co-authored-by: Cline Evaluation <cline@example.com> * ripping out test build flag (RooCodeInc#3043) Co-authored-by: Cline Evaluation <cline@example.com> * cleaning up evals.env logic in extension.ts (RooCodeInc#3045) Co-authored-by: Cline Evaluation <cline@example.com> * ENG-516 Slash commands (RooCodeInc#3044) * scroll * menu * changeset * nit * What's yer path? (#3047) * update extension imports to use aliasing * changeset * ENG-484 Enhance fixWithCline command execution by focusing chat input (RooCodeInc#3028) * Enhance fixWithCline command execution by focusing chat input and adding a delay before processing the fixWithCline command. * feat: add OpenRouter base URL and balance display component * feat: add OpenRouter base URL and balance display component * feat: add OpenRouter base URL and balance display component * new_task prompt (RooCodeInc#3049) * prompt * changeset * words * prettier * Added metadata --------- Co-authored-by: yt3trees <57471763+yt3trees@users.noreply.github.com> Co-authored-by: pashpashpash <nik@cline.bot> Co-authored-by: Cline Evaluation <cline@example.com> Co-authored-by: Toshii <94262432+0xToshii@users.noreply.github.com> Co-authored-by: Evan <58194240+celestial-vault@users.noreply.github.com> Co-authored-by: nomaven <arafat.da.khan@gmail.com>

cte added 2 commits April 29, 2025 15:37

Execa fallback

a07d67c

Fix tsc error

cfb1e27

github-project-automation bot added this to Roo Code Roadmap Apr 29, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Apr 29, 2025

cte changed the title ~~Cte/execa fallback~~ Fall back to execa if VSCode terminal integration fails Apr 29, 2025

Update the UI error

d1495d8

cte marked this pull request as ready for review April 30, 2025 00:12

cte requested a review from mrubens as a code owner April 30, 2025 00:12

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 30, 2025

dosubot bot added the Enhancement New feature or request label Apr 30, 2025

Merge main

335cb67

mrubens approved these changes Apr 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2025

cte added 5 commits April 29, 2025 19:49

Add missing translations

5a66643

Roo modes emojis

35a4142

Rename terminalInfo to terminal

8c9dd9a

Add changeset

c4c8870

This test is failing on Windows

41dfca2

ellipsis-dev bot reviewed Apr 30, 2025

View reviewed changes

src/api/providers/__tests__/requesty.test.ts Show resolved Hide resolved

Disable all network connection in jest

7154cb8

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 30, 2025

ellipsis-dev bot reviewed Apr 30, 2025

View reviewed changes

scripts/run-tests.js Show resolved Hide resolved

Skip for now; will figure it out later

7c010a2

ellipsis-dev bot reviewed Apr 30, 2025

View reviewed changes

src/api/providers/fetchers/__tests__/openrouter.test.ts Show resolved Hide resolved

cte merged commit 7863303 into main Apr 30, 2025
12 checks passed

cte deleted the cte/execa-fallback branch April 30, 2025 04:10

github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 30, 2025

mrubens reviewed Apr 30, 2025

View reviewed changes

.roomodes

{

"slug": "test",

"name": "Test",

"name": "🧪 Test",

Copy link
Copy Markdown

Collaborator

mrubens Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, thank you for this!

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025

new_task prompt (RooCodeInc#3049)

04d1f1d

* prompt * changeset * words

weiz3630 referenced this pull request in weiz3630/zgsm May 9, 2025

Fall back to execa if VSCode terminal integration fails (#3049)

54b0d4f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fall back to execa if VSCode terminal integration fails#3049

Fall back to execa if VSCode terminal integration fails#3049
cte merged 11 commits intomainfrom
cte/execa-fallback

cte commented Apr 29, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

changeset-bot bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

ellipsis-dev bot commented Apr 30, 2025

Uh oh!

mrubens left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrubens Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cte commented Apr 29, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Implementation

Screenshots

How to Test

Get in Touch

Uh oh!

changeset-bot bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

ellipsis-dev bot commented Apr 30, 2025

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrubens Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cte commented Apr 29, 2025 •

edited by ellipsis-dev bot

Loading

changeset-bot bot commented Apr 29, 2025 •

edited

Loading