Skip to content

Improve command execution component#3057

Merged
cte merged 5 commits intomainfrom
cte/improve-command-execution-component
Apr 30, 2025
Merged

Improve command execution component#3057
cte merged 5 commits intomainfrom
cte/improve-command-execution-component

Conversation

@cte
Copy link
Copy Markdown
Collaborator

@cte cte commented Apr 30, 2025

Context

Area.mp4

If the VSCode terminal fails then we immediately execute the command using the new mechanism, update your setting, show a warning, and then proceed as normal.


Important

Enhances command execution with a fallback mechanism, UI updates for command status, and a kill command button.

  • Behavior:
    • Adds a kill command button to the command execution component.
    • Implements fallback mechanism for command execution if VSCode terminal fails, updating settings and showing a warning.
    • Updates CommandExecution component to display command status and allow aborting running commands.
  • Command Execution:
    • Adds executionId to ExecuteCommandOptions in executeCommandTool.ts and attemptCompletionTool.ts.
    • Sends command execution status updates to webview in executeCommand() in executeCommandTool.ts.
    • Handles shell execution start and completion events in BaseTerminal.ts and ExecaTerminalProcess.ts.
  • UI Components:
    • Updates CommandExecution.tsx to show running status, PID, and exit status.
    • Adds CheckpointWarning.tsx for displaying checkpoint initialization warnings.
    • Modifies ChatView.tsx and ChatRow.tsx to integrate new command execution features.
  • Types and Schemas:
    • Adds CommandExecutionStatus type and schema in schemas/index.ts.
    • Updates ExtensionMessage.ts to include commandExecutionStatus type.
  • Misc:
    • Removes CommandExecution.test.tsx as it is no longer relevant.

This description was created by Ellipsis for 16eaf6b. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2025

🦋 Changeset detected

Latest commit: 16eaf6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Apr 30, 2025
@cte cte merged commit 1d7569b into main Apr 30, 2025
10 of 11 checks passed
@cte cte deleted the cte/improve-command-execution-component branch April 30, 2025 06:57
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 30, 2025
weiz3630 referenced this pull request in weiz3630/zgsm May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant