Resetting ChatColor's italic font before assigning it to item name or lore#30
Merged
SamJakob merged 3 commits intoSamJakob:masterfrom May 6, 2024
Merged
Resetting ChatColor's italic font before assigning it to item name or lore#30SamJakob merged 3 commits intoSamJakob:masterfrom
SamJakob merged 3 commits intoSamJakob:masterfrom
Conversation
# Conflicts: # src/main/java/com/samjakob/spigui/item/ItemBuilder.java
Owner
|
Agreed. I was on the fence about overriding it by default but honestly I think it's very rarely someone would want the italic font when using SpiGUI and it's easy enough to add back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, items have italic font if renamed in any way. Added ChatColor.RESET to the item's name, resetting the italic font. This also applies to lore
I believe the text should be normal by default and, if needed, changed to italic by the user
(Ignore the double commit, I still don't know how git works)