Skip to content

Remove is-interactive, inline the TTY check#7198

Open
ryancbahan wants to merge 1 commit into04-03-04-03-remove-http-proxyfrom
04-03-04-03-remove-is-interactive
Open

Remove is-interactive, inline the TTY check#7198
ryancbahan wants to merge 1 commit into04-03-04-03-remove-http-proxyfrom
04-03-04-03-remove-is-interactive

Conversation

@ryancbahan
Copy link
Copy Markdown
Contributor

@ryancbahan ryancbahan commented Apr 3, 2026

Summary

  • Replace is-interactive package with inline logic: process.stdout.isTTY && TERM !== 'dumb' && !CI
  • The package was 6 lines; the inline replacement is identical behavior
  • Works cross-OS: isTTY is a Node.js built-in available on all platforms

Test plan

  • 5 new tests covering all branches (TTY, non-TTY, dumb terminal, CI set, CI empty string)
  • All 29 local.test.ts tests pass
  • tsc --noEmit passes
  • Lint passes

The package was a 6-line function checking process.stdout.isTTY,
TERM !== 'dumb', and absence of CI env var. Inline the logic directly
in isTerminalInteractive(). Added 5 tests covering all branches:
TTY + normal term, non-TTY, dumb terminal, CI set, CI empty string.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor Author

@ryancbahan ryancbahan marked this pull request as ready for review April 3, 2026 23:34
@ryancbahan ryancbahan requested a review from a team as a code owner April 3, 2026 23:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant