feat(vocab): W23A evidence-gated physical bases for grammar gap closure#13
Merged
Simon-McIntosh merged 1 commit intomainfrom Apr 26, 2026
Merged
feat(vocab): W23A evidence-gated physical bases for grammar gap closure#13Simon-McIntosh merged 1 commit intomainfrom
Simon-McIntosh merged 1 commit intomainfrom
Conversation
…losure Add 7 physical_base tokens to close vocabulary gaps identified in W22B review score analysis: Class 2 — Physics compound nouns: - bootstrap_current_density: j_bootstrap (core_profiles, N=5 IDSs) - rotation_frequency: rotation_frequency_tor (core_profiles, N=8+) - mach_number: mach_number_parallel (langmuir_probes, N=3) - resistivity: wall/*/resistivity (wall, cryostat, N=6) Class 2 — Viscosity current density compounds: - heat_viscosity_current_density: j_heat_viscosity (edge/plasma_profiles, N=4) - parallel_viscosity_current_density: j_parallel_viscosity (N=4) - perpendicular_viscosity_current_density: j_perpendicular_viscosity (N=4) All tokens meet the N>=3 evidence gate. Sonic rotation frequency is not added as a separate base because subject=sonic + base=rotation_frequency correctly composes to sonic_rotation_frequency via existing grammar.
|
Simon-McIntosh
added a commit
to Simon-McIntosh/imas-codex
that referenced
this pull request
Apr 26, 2026
…ions Merge of Simon-McIntosh/IMAS-Standard-Names#13 (w23a-vocab-grammar-gaps). Adds 7 evidence-gated physical_base tokens: - bootstrap_current_density, heat_viscosity_current_density, mach_number - parallel_viscosity_current_density, perpendicular_viscosity_current_density - resistivity, rotation_frequency ISN version: 0.7.0rc28.dev2+ge444ca8a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W23A Vocabulary Extension — Grammar Gap Closure
Context
W22B review score analysis identified three vocabulary gap classes dragging mean scores from ~0.660 to below the 0.733 target. This PR addresses Class 2 (physics compound nouns) with 7 new
physical_basetokens.Evidence & Rationale
bootstrap_current_densitycore_profiles/profiles_1d/j_bootstraprotation_frequencycore_profiles/profiles_1d/ion/rotation_frequency_tormach_numberlangmuir_probes/reciprocating/plunge/mach_number_parallelresistivitywall/*/resistivity,cryostat/*/resistivityheat_viscosity_current_densityedge_profiles/ggd/j_heat_viscosityparallel_viscosity_current_densityedge_profiles/ggd/j_parallel_viscosityperpendicular_viscosity_current_densityedge_profiles/ggd/j_perpendicular_viscosityAll tokens meet the N>=3 evidence gate.
Test Results
1107 passed, 68 xfailed, 53 warnings.