Skip to content

Update configLocation.js#1025

Closed
adammendoza wants to merge 1 commit intoSoundnode:masterfrom
adammendoza:patch-1
Closed

Update configLocation.js#1025
adammendoza wants to merge 1 commit intoSoundnode:masterfrom
adammendoza:patch-1

Conversation

@adammendoza
Copy link
Copy Markdown

Fixes #1024

First time running this on a Mac so the userConfigPath does not exists. The code was erroring out on

 if (!fs.statSync(userConfigPath).isDirectory()) {

The new code is tested as working on Mac.

createUserConfig(userConfigPath) // is probably no longer needed.

First time running this on a Mac so the userConfigPath does not exists. The code was erroring out on
` if (!fs.statSync(userConfigPath).isDirectory()) {`
The new code is tested as working on Mac. 
createUserConfig(userConfigPath) is probably no longer needed.
@jakejarrett jakejarrett requested review from jakejarrett and removed request for jakejarrett November 1, 2017 21:20
@jakejarrett jakejarrett self-assigned this Nov 1, 2017
@jakejarrett
Copy link
Copy Markdown
Member

Will check this out this weekend 👍

@jakejarrett
Copy link
Copy Markdown
Member

jakejarrett commented Dec 31, 2017

Sorry for getting to this so late.

Might be better to just wrap this in an OS Check, eg if (process.platform === 'darwin') return; otherwise it may break on windows/linux in situations that i haven't tested.

EDIT:
Also this depends on the outcome of #1017 as these both achieve the same goal, but the other PR maintains the same check for the folder (desired)

@jakejarrett
Copy link
Copy Markdown
Member

Closing this in favor of #1016 which keeps the functionality that was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants