Closed
Conversation
First time running this on a Mac so the userConfigPath does not exists. The code was erroring out on
` if (!fs.statSync(userConfigPath).isDirectory()) {`
The new code is tested as working on Mac.
createUserConfig(userConfigPath) is probably no longer needed.
Member
|
Will check this out this weekend 👍 |
Member
|
Sorry for getting to this so late. Might be better to just wrap this in an OS Check, eg EDIT: |
Member
|
Closing this in favor of #1016 which keeps the functionality that was intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1024
First time running this on a Mac so the userConfigPath does not exists. The code was erroring out on
The new code is tested as working on Mac.