[Ready for review] Add vstack atom through transpose(hstack(transpose[args]))#52
Merged
Transurgeon merged 3 commits intomainfrom Mar 26, 2026
Merged
[Ready for review] Add vstack atom through transpose(hstack(transpose[args]))#52Transurgeon merged 3 commits intomainfrom
Transurgeon merged 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reuses existing hstack and transpose implementations instead of a from-scratch approach, avoiding manual row-interleaving logic. Removes the original vstack-plan.md since the composition strategy supersedes it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Transurgeon
changed the title
6 tasks
Transurgeon
changed the title
dance858
reviewed
Mar 26, 2026
Collaborator
|
Looks great WZZ! I like this implementation of vstack a lot more. Very neat. Feel free to merge after having removed ux and uy. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dance858 I've prompted claude to implement our idea of reusing hstack for vstack.. looks pretty clean to me.
please double check the tests and let's merge this!