fix: prevent hang on coordinator dealloc and concurrent WindowOpener waits#601
Merged
fix: prevent hang on coordinator dealloc and concurrent WindowOpener waits#601
Conversation
…waits - Resume saveCompletionContinuation in MainContentCoordinator.deinit to prevent permanent hang if coordinator deallocates during save - Support multiple concurrent waitUntilReady() callers in WindowOpener by using an array of continuations instead of a single optional
…flow saveAndClose() checked rightPanelState.editState.hasEdits before changeManager.hasChanges, causing it to take the sidebar-only save path (which doesn't execute SQL) when the inspector panel reflected data grid edits. This matched the user's report: Cmd+W → Save behaved identically to Cmd+W → Don't Save. The regular saveChanges() already had the correct priority order (data grid first, sidebar second). This aligns saveAndClose() with that logic.
datlechin
force-pushed
the
fix/perf-audit-tier1
branch
from
121deb4 to
52dccf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes from the performance audit (Tier 1 critical items):
saveCompletionContinuation hang —
MainContentCoordinator.deinitnow resumes the pending save continuation withfalsebefore cleanup. Previously, if the coordinator was deallocated mid-save (force close, SwiftUI view discard), the awaiting Task inMainContentCommandActions.closeAfterSave()would hang forever.WindowOpener concurrent waiters —
readyContinuation(singleCheckedContinuation?) replaced withreadyContinuations: [CheckedContinuation]. Multiple subsystems can now awaitwaitUntilReady()concurrently at cold launch without the second caller overwriting and orphaning the first caller's continuation.The third audit item (
usleepinAutoTOTPProvider) was re-assessed as correct — it runs on a dedicated detached thread, not the cooperative pool.Test plan