fix: Tests - Update middleware tests to use Starlette 1.0.0 routing API#218
Open
morgan-wowk wants to merge 1 commit intomasterfrom
Open
fix: Tests - Update middleware tests to use Starlette 1.0.0 routing API#218morgan-wowk wants to merge 1 commit intomasterfrom
morgan-wowk wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The test suite was using Starlette's deprecated
@app.route()decorator to register route handlers in middleware and concurrency tests. This API was removed in Starlette 1.0.0, causing 12 tests to fail withAttributeError: 'Starlette' object has no attribute 'route'.Fix
Updated the affected tests in
test_instrumentation_request_middleware.pyandtest_request_id_concurrency.pyto use the current Starlette routing API — defining handlers as plain functions and passing them to theStarletteconstructor viaRouteobjects:Backwards Compatibility
Starlette(routes=[Route(...)])is the recommended API and works across all supported Starlette versions, so this change is fully backwards compatible.References
Screenshots / links
StarletteandRouterdecorators Kludex/starlette#1897