Fix 1004 - add function body upon call to add_fct#1006
Merged
ColinFay merged 2 commits intoThinkR-open:devfrom Mar 29, 2023
Merged
Fix 1004 - add function body upon call to add_fct#1006ColinFay merged 2 commits intoThinkR-open:devfrom
ColinFay merged 2 commits intoThinkR-open:devfrom
Conversation
- fix 1004 adding bare skeleton function body - function name taken from 'name' arg to add_fct
Member
|
Thanks a lot @ilyaZar! For the body, my general philosophy is: "if you have to remove something every time, you probably need to prevent it from being added in the first place" :) So yeah I would prefer an empty body & params if that's ok with you to make the change ? |
Contributor
Author
|
That makes sense! |
Member
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per commit message:
So
add_module(fct = "fct_name")creates a file "fct_name" without pulling above template. This could be fixed, though I am not sure what the exact behavior should be. #1004 explicitly asks for changingadd_fct()notadd_module().The body is a matter of taste, I am happy to change it :)