Skip to content

hotfix: remove a warning and a note from devtools::check()#1039

Merged
ColinFay merged 2 commits intoThinkR-open:devfrom
ilyaZar:1038-hotfix_missing_docs_and_imports
May 24, 2023
Merged

hotfix: remove a warning and a note from devtools::check()#1039
ColinFay merged 2 commits intoThinkR-open:devfrom
ilyaZar:1038-hotfix_missing_docs_and_imports

Conversation

@ilyaZar
Copy link
Copy Markdown
Contributor

@ilyaZar ilyaZar commented May 20, 2023

Edited:

As per #1038

  1. remove warning due to "Undocumented arguments in documentation object" in fill_desc()

  2. add forgotten @importFrom utils person that caused a note in devtools::check()

  3. add missing role = c('aut', 'cre') to 01_start.R and corresponding vingettes/a_start.Rmd to make 01_start.R run smoothly when a fresh golem is created

ilyaZar added 2 commits May 20, 2023 18:55
- remove warning due "Undocumented arguments in documentation object" in fill_desc

- add forgotten @importFrom utils person that caused a note
- devtools::build_readme() cannot be run when aut/cre is missing
@ColinFay ColinFay merged commit 3e925b1 into ThinkR-open:dev May 24, 2023
@ColinFay
Copy link
Copy Markdown
Member

Thank you!

@ilyaZar ilyaZar deleted the 1038-hotfix_missing_docs_and_imports branch April 4, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants