Release candidate for 0.4.0 by ColinFay · Pull Request #961 · ThinkR-open/golem

ColinFay · 2022-12-14T14:46:48Z

Todo before releasing this version

Restore the automatically build shiny app sent to https://github.com/ThinkR-open/golemmetrics
Build an app with the version 0.4.0 inside a fresh R installation to be sure that everything works as expected
Check for dev dependency when creating a golem create_golem should advise to install dev_dependencies if there are not all here #915
Recheck that all the bootstrap functions are still there
Run devdepcheck

We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4

Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev # Conflicts: # DESCRIPTION # NEWS.md # R/add_dockerfiles.R # R/modules_fn.R # man/dockerfiles.Rd # tests/testthat/test-zzzzzzzzzz.R

Issue Add a maintenance mode ? #820

* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001

* fix allow pkgload no to be installed * fix document_and_reload rd * chore update NEWS and bump version * fix force repos in test to avoid "trying to use CRAN without setting a mirror"

* remove cli and crayon from hard deps

Issue #923

…y-pick

#961

fix : allow using `add_dockerfile_with_renv without` attachment and/or detect if package is missing

tags: fix, doc Why? - I need to be able to commit right after running the complete "dev/01_dev.R" How? - To commit, I need the Readme.md file to be created, after I created the Readme.Rmd file. - devtools::build_readme() allows to install the package temporarily with its last version to be able to knit the Readme.Rmd in the last good conditions

fix: allow to build readme in 01_start

* Pass `require_suggets` to `attachment_create_renv_for_prod` * feat : force check_if_suggests_is_installed = FALSE in renv creation * feat : add test to check suggested package are not in renv.lock * fix : explictly use library(appname) before launching an app un Dockerfile issue : #978 * fix : update add_dockerfile_with_renv * fix : check_installed is more cleaver * fix : add {renv} to dev_deps (its already in {dockerfiler}'s deps, but it seems safer to do this. --------- Co-authored-by: Stephen Holsenbeck <stephen@virgalabs.io>

ColinFay · 2023-02-03T11:05:50Z

> revdep_summary()
✔ activAnalyzer 2.0.0                    ── E: 0     | W: 0     | N: 0    
✔ apisensr 0.3.0                         ── E: 0     | W: 0     | N: 1    
✔ babsim.hospital 11.8.8                 ── E: 0     | W: 0     | N: 1    
✔ biodosetools 3.6.1                     ── E: 0     | W: 0     | N: 0    
✔ bs4Dash 2.2.1                          ── E: 0     | W: 0     | N: 1    
✔ designer 0.2.0                         ── E: 0     | W: 0     | N: 0    
I discoveR 3.1.2                         ── E: 1     | W: 0     | N: 0    
✔ dragon 1.2.1                           ── E: 0     | W: 0     | N: 1    
✔ fdapaceShiny 1.0.5                     ── E: 0     | W: 0     | N: 0    
✔ FielDHub 1.2.1                         ── E: 0     | W: 0     | N: 0    
✔ forecasteR 1.1.6                       ── E: 0     | W: 0     | N: 0    
✔ gwpcormapper 0.1.3                     ── E: 0     | W: 0     | N: 1    
✔ InterCellar 2.4.0                      ── E: 0     | W: 0     | N: 2    
✔ IsoCor 0.1.40                          ── E: 0     | W: 0     | N: 1    
✔ kesernetwork 0.1.0                     ── E: 0     | W: 0     | N: 0    
I loadeR 1.1.3                           ── E: 1     | W: 0     | N: 0    
✖ MainExistingDatasets 1.0.1             ── E: 0     | W: 0  +1 | N: 1    
✔ MicrobiomeProfiler 1.4.0               ── E: 0     | W: 0     | N: 1    
E multiSight                             ── E: ?/?   | W: ?/?   | N: ?/?  
I OlympicRshiny 1.0.0                    ── E: 1     | W: 0     | N: 0    
✔ packer 0.1.3                           ── E: 0     | W: 0     | N: 0    
✔ PERK 0.0.9.2                           ── E: 0     | W: 0     | N: 0    
✔ phecodemap 0.1.0                       ── E: 0     | W: 0     | N: 1    
✔ predictoR 2.0.7                        ── E: 0     | W: 0     | N: 0    
✔ regressoR 2.0.1                        ── E: 0     | W: 0     | N: 1    
✔ ReviewR 2.3.8                          ── E: 0     | W: 0     | N: 1    
✔ rsqliteadmin 1.0.1                     ── E: 0     | W: 0     | N: 0    
✔ ShinyLink 0.2.2                        ── E: 0     | W: 0     | N: 0    
I shinyTempSignal 0.0.3                  ── E: 1     | W: 0     | N: 0    
T spatialLIBD 1.10.1                     ── E: 1     | W: 0     | N: 2    
✔ tcgaViz 1.0.1                          ── E: 0     | W: 0     | N: 0    
✔ tidyCDISC 0.1.0                        ── E: 1     | W: 0     | N: 1    
I tripr 1.4.0                            ── E: 1     | W: 0     | N: 0    
✔ viewpoly 0.3.2                         ── E: 0     | W: 0     | N: 0    
✔ wpm 1.8.0                              ── E: 0     | W: 0     | N: 0

Fix #993

* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001

ColinFay and others added 30 commits October 12, 2022 21:23

chore: merging changes from CRAN upload (#928)

e64fd04

chore: version bump

07e31b7

We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4

Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev

5aae6b4

feat: removed {usethis} hard dep (#929)

e6f3fad

fix: unit test requires dependencies in suggests (#919)

9a809bb

refactor: check_installed in their own files (#931)

4f77e1b

feat: Make cat functions conditional to an options (#934)

0313b59

doc: NEWS update & version bump

9b072a5

chore: version bump

8eb0719

We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4

chore: merging changes from CRAN upload (#928)

1238ce9

feat: removed {usethis} hard dep (#929)

4f0eb33

fix: unit test requires dependencies in suggests (#919)

9b68398

refactor: check_installed in their own files (#931)

fccedc8

feat: Make cat functions conditional to an options (#934)

beeda81

chore: merge after rebase

6d4c532

Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev # Conflicts: # DESCRIPTION # NEWS.md # R/add_dockerfiles.R # R/modules_fn.R # man/dockerfiles.Rd # tests/testthat/test-zzzzzzzzzz.R

doc: improve documentation of dockerfile related functions (#939)

a1f80f5

chore: version bump & news update

5c4d10e

Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev

d630bc0

feat: fill_desc allows to set package version (#941)

842d0c3

chore: version bump & news update

38df42c

style: styler changes

a75e828

feat: remove {desc} as hard dep (#940)

f8461c2

feat: Create html template for maintenance mode

43a40f4

Issue Add a maintenance mode ? #820

feat: Create documentation for maintenance page

568a624

refactor: changed the text on screen for maintenance page

3267323

refactor: renamed env var to GOLEM_MAINTENANCE_ACTIVE

f32f753

doc: some vignette rewritting and additions

cc608c9

Fix 944 and correct CI (#947)

acc054b

* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001

fix dev branch (#948)

5c75618

* fix allow pkgload no to be installed * fix document_and_reload rd * chore update NEWS and bump version * fix force repos in test to avoid "trying to use CRAN without setting a mirror"

draft : 950 without cli (#951)

63ac852

* remove cli and crayon from hard deps

ColinFay and others added 7 commits December 23, 2022 09:24

Merge pull request #966 from ThinkR-open/issue-915

c714bdf

doc: entry in news

525e97d

Add a demo shinyapps.io snippet for the _03_deploy_ file

2c869d3

fix: removed the dot file from deployment

22f3467

Issue #923

Merge pull request #967 from ThinkR-open/issue-923-yogat3ch-for-cherr…

4a0b428

…y-pick

doc: news update

9ce9150

hotfix: check that all boostrap fns are there

85a8211

#961

ColinFay mentioned this pull request Dec 23, 2022

hotfix: check that all boostrap fns are there #968

Merged

ColinFay and others added 8 commits December 23, 2022 10:23

Merge pull request #968 from ThinkR-open/hotifx-bootstrap-funs

e761c3b

fix: hotix typo

942c998

typo: hotfix typo message check_dev_deps_are_installed

bf03e50

Update add_dockerfiles_renv.R (#976)

5eb61fb

fix : allow using `add_dockerfile_with_renv without` attachment and/or detect if package is missing

Merge pull request #979 from ThinkR-open/dev-build-readme

c60f62d

fix: allow to build readme in 01_start

fix : URLs are now OK # 980 (#981)

f576d0f

ilyaZar and others added 9 commits February 22, 2023 15:19

Fix #993

da7cbe7

Merge pull request #994 from ilyaZar/dev

9f8630f

Fix #993

test: new test and deploy script

9c09c01

ci: forcing the repos

bbcc392

ci: updated GA

a926b4c

ci: use_dev_package in build.R

a9051e6

doc: only one return tag

585cc03

doc: doc cleaning before CRAN release

1b4018a

Fix 944 and correct CI

08f050f

* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001

ColinFay marked this pull request as ready for review March 10, 2023 10:41

ColinFay added 2 commits March 10, 2023 11:43

Merge branch 'master' into dev

383644f

fix: run the function instead of $ its body

1e79e54

ColinFay merged commit ce67fa5 into master Mar 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release candidate for 0.4.0#961

Release candidate for 0.4.0#961
ColinFay merged 64 commits intomasterfrom
dev

ColinFay commented Dec 14, 2022 •

edited

Loading

Uh oh!

ColinFay commented Feb 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ColinFay commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo before releasing this version

Uh oh!

ColinFay commented Feb 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ColinFay commented Dec 14, 2022 •

edited

Loading