Skip to content

Change default capture method to WGA #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toufool merged 1 commit into from
Feb 18, 2023
Merged

Change default capture method to WGA #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ Refer to the [build instructions](build%20instructions.md) if you'd like to buil

#### Capture Method

- **BitBlt** (fastest, least compatible)
A good default fast option. But it cannot properly record OpenGL, Hardware Accelerated or Exclusive Fullscreen windows.
The smaller the selected region, the more efficient it is.
- **Windows Graphics Capture** (fast, most compatible, capped at 60fps)
Only available in Windows 10.0.17134 and up.
Due to current technical limitations, Windows versions below 10.0.0.17763 require having at least one audio or video Capture Device connected and enabled.
Allows recording UWP apps, Hardware Accelerated and Exclusive Fullscreen windows.
Adds a yellow border on Windows 10 (not on Windows 11).
Caps at around 60 FPS.
- **BitBlt** (fastest, least compatible)
The best option when compatible. But it cannot properly record OpenGL, Hardware Accelerated or Exclusive Fullscreen windows.
The smaller the selected region, the more efficient it is.
- **Direct3D Desktop Duplication** (slower, bound to display)
Duplicates the desktop using Direct3D.
It can record OpenGL and Hardware Accelerated windows.
Expand Down
22 changes: 11 additions & 11 deletions src/capture_method/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,6 @@ def get(self, __key: CaptureMethodEnum):
)

CAPTURE_METHODS = CaptureMethodDict()
CAPTURE_METHODS[CaptureMethodEnum.BITBLT] = CaptureMethodInfo(
name="BitBlt",
short_description="fastest, least compatible",
description=(
"\nA good default fast option. But it cannot properly record "
"\nOpenGL, Hardware Accelerated or Exclusive Fullscreen windows. "
"\nThe smaller the selected region, the more efficient it is. "
),

implementation=BitBltCaptureMethod,
)
if ( # Windows Graphics Capture requires a minimum Windows Build
WINDOWS_BUILD_NUMBER >= WGC_MIN_BUILD
# Our current implementation of Windows Graphics Capture does not ensure we can get an ID3DDevice
Expand All @@ -147,6 +136,17 @@ def get(self, __key: CaptureMethodEnum):
),
implementation=WindowsGraphicsCaptureMethod,
)
CAPTURE_METHODS[CaptureMethodEnum.BITBLT] = CaptureMethodInfo(
name="BitBlt",
short_description="fastest, least compatible",
description=(
"\nThe best option when compatible. But it cannot properly record "
"\nOpenGL, Hardware Accelerated or Exclusive Fullscreen windows. "
"\nThe smaller the selected region, the more efficient it is. "
),

implementation=BitBltCaptureMethod,
)
CAPTURE_METHODS[CaptureMethodEnum.DESKTOP_DUPLICATION] = CaptureMethodInfo(
name="Direct3D Desktop Duplication",
short_description="slower, bound to display",
Expand Down