fix method declarations to conform with napi default for methods#1510
Merged
daniellockyer merged 3 commits intoTryGhost:masterfrom May 21, 2022
Merged
fix method declarations to conform with napi default for methods#1510daniellockyer merged 3 commits intoTryGhost:masterfrom
daniellockyer merged 3 commits intoTryGhost:masterfrom
Conversation
Contributor
Author
|
@kewde can you please consider this for merging? Thanks! |
Contributor
|
@alexanderfloh Would you be able to rebase the PR? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix native method implementation to use the proper default options for methods (see nodejs/node-addon-api#811 for details).
This has the beneficial effect that it allows instrumenting the sqlite3 API for tools like Open Telemetry or other APM tools.
Note: instrumentation was possible before sqlite3 v5 and the switch to NAPI.